Option to disable auto-close parenthesis?

acomagu · September 13, 2021, 2:24am

I want to disable auto-closing parenthesis feature.

acomagu · September 13, 2021, 2:26am

I have looked for the code which does this, but I couldn’t. Anyone knows?

spetey · September 14, 2021, 4:33pm

I agree - I often find myself going back to add markup somewhere in the middle of text, and end up having to erase the auto-paired bits. I would turn this off if I had the option. (Or maybe even better: auto-pair only if it’s at the end of a line of text, not the middle?)

ajeetdsouza · September 25, 2021, 11:51pm

Agreed. Logseq’s current autopairing is not very intuitive yet, it would be nice if we could just disable this feature outright. Disabling autopair should also disable the feature where backspacing once on ** deletes both the asterisks.

pospi · November 19, 2021, 11:28pm

+1 to this, I also find it impedes my writing flow more than it assists.

Ideally we could have separate options to control autopairing of quotes and brackets so that we can tailor to our needs. I find the quote matching more troublesome than the bracket matching since most bracket matching involves page or block refs and is therefore usually finalised via the autocomplete dialog. Quote matching trips me up every time.

EleanorKonik · January 27, 2022, 3:03pm

Can confirm that this is very frustrating. “How do I disable auto closing of syntax markup” was like the second thing I looked up upon starting to use Logseq “for real” and I’m very disappointed to find out that it’s not possible

gestaltist · January 27, 2022, 3:05pm

+1 from me. In addition, it should be selective. E.g., I typically want to auto-close wikilinks but not normal brackets.

JeRoen · January 27, 2022, 4:36pm

Make it an option to disable is fine, but make it work correctly seems to be the way forward. I do like the auto-close parenthesis but it should only autoclose when text is selected. before and after the selected text.

If you want to make it even nicer, when you type a ( immediatly before a word (so without a space) it should add the typed ( where you typed it and also add a ) at the end of that word, without explicitly selecting it.

Gary_O · January 28, 2022, 4:51pm

I like the auto-close parens. But you’re right it is not perfect yet. For one thing, backticks don’t auto-close the same way parens do: I mean if you type exactly this: (foo) including the close-paren, your cursor ends up after the close paren – it correctly doesn’t duplicate the close. Same with [[foo]]; as you type the close brackets it skips over them. But if you type backquote f o o backquote (I can’t get backquotes into this forum) it duplicates the trailing backquote (twice!) instead of skipping over it. The inconsistency drives me crazy.

isosphere · March 10, 2022, 1:03am

I believe this functionality is called autopair, and it can be found here:

github.com

logseq/logseq/blob/46b86b081b2ad80f58363e211c506fd4012db5c4/src/main/frontend/handler/editor.cljs#L1704

    
      
                    (keys autopair-map)))
          
          
(def autopair-when-selected
            #{"*" "^" "_" "=" "+" "/"})
          
          
(def delete-map
            (assoc autopair-map
                   "$" "$"
                   ":" ":"))
          
          
(defn autopair
            [input-id prefix _format _option]
            (let [value (get autopair-map prefix)
                  selected (util/get-selected-text)
                  postfix (str selected value)
                  value (str prefix postfix)
                  input (gdom/getElement input-id)]
              (when value
                (when-not (string/blank? selected) (reset! *selected-text selected))
                (let [[prefix _pos] (commands/simple-replace! input-id value selected
                                                              {:backward-pos (count postfix)

I think this is the usual place it is triggered, based on commit history:

github.com

logseq/logseq/blob/46b86b081b2ad80f58363e211c506fd4012db5c4/src/main/frontend/handler/editor.cljs#L2901

    
      
          (do
            (autopair input-id "[" format nil)
            (util/stop e))
          
          
(and (not (string/blank? (util/get-selected-text)))
               (contains? keycode/left-paren-keys key))
          (do
            (util/stop e)
            (autopair input-id "(" format nil))
          
          
(contains? (set (keys autopair-map)) key)
          (do
            (util/stop e)
            (autopair input-id key format nil))
          
          
hashtag?
          (do
            (commands/handle-step [:editor/search-page-hashtag])
            (if (= key "#")
              (state/set-last-pos! (inc (cursor/pos input))) ;; In keydown handler, the `#` is not inserted yet.
              (state/set-last-pos! (cursor/pos input)))

It does not currently look conditional. I am not familiar with Clojure or any LISP-style language so I can’t quite see how to change that at present.

I am also in favour of being able to disable this functionality, even if just by manually adding a line to my config file. Like @pospi I find that it impedes me more than it helps, but maybe I type weird.

I hope my code links are helpful, sorry it’s not a pull request.

acomagu · March 25, 2022, 10:33pm

Really Helpful! Thanks!

I tried removing all “autopair” function calling and seems working as expected at first, but I noticed auto-completing for “[[ ]]” and “(( ))” is still remains…

Movie

I guess these behavior are implemented in another function, but I couldn’t find also…

The current status of my change

Nnotm · June 13, 2022, 1:57pm

+1, I turn it off in every application that has it and was surprised to learn that that’s not possible in Logseq.

Woshiluo · July 2, 2022, 12:45am

Same request, auto-close parenthesis may break sth. I think it’s reasonable to add this option and leave this choice to user.

1984 · October 11, 2022, 6:19am

Note that you can select a phrase and then type an opening parenthesis and Logseq closes it around what you selected. Initially got annoyed by Logseq trying to help but I’ve now used it to my advantage.

ohkyook · December 6, 2022, 5:16am

Please give users options what to choose.

oluckyman · December 15, 2022, 1:54pm

It’s really frustrating. No-feature is better than poorly-implemented-feature.
Auto-pair is common in code editors and it woks seamlessly, because there are nuances how it should work, it’s not just doubling a character.
Say, I want to add backtick to finish line of code. I put the cursor to the end:

`const x = 1⎸

and type backtick. And Logseq puts two backticks:

`const x = 1`⎸`

It does not make any sense to add closing backtick when I’m at the end of the word! what makes it worse is that if I hit backspace, to delete one unnecessary backtick, it deletes them both.
So the only way to add a backtick at the end of the word is to:

Hit backtick
Hit right arrow to place the cursor after the second backtick
Hit backspace to remove unnecessary backtick.
Feel productive.

It is not helpful at all. And it’s not acceptable in tool for thought like Logseq, because it breaks the flow.
No feature is better than a broken feature.

gavento · February 7, 2023, 11:07am

As @acomagu pointed out, the set of characters to autopair is defined in autopair-map. It would be nice if it was possible to edit this at least in the edn config - either to just force it empty via (def autopair-map {}), or even configure your own set of pairs.

Synchronicity · March 6, 2023, 2:46am

Adding my strong support for this feature request. I find autopairing much more annoying than helpful.

Gucci_Ming · May 1, 2023, 11:58am

another strong support from me. this would make the writing experience better for many users

John_Doe · May 16, 2023, 8:33pm

When cursor just before a word auto-pairing should be disabled.
This is about symbols

`
[
)
~

maybe some other I missed

I should help avoid such situation

[[]]my_super_tag